Graphical EPG highlights active timers, but does not offer to allow you to change them

[Ian Brabham]

In the Graphical EPG existing timers are highlighted. If you navigate to such a highlighted timer and it is an exact match to the EPG data, you are offered to change it with the Green button, i.e. Green button flips from "Add Timer" to "Change Timer".

If the EPG data match is not exact, pressing Green adds a new timer that approximately duplicates the existing timer.

If the existing timers is close enough to be highlighted red, as a defined timer, then the Green button should offer the "Change Timer" option rather than the "Add Timer" option.

Reproduction steps

1. Enter the Graphical EPG.
2. Choose a program that repeats daily and the TV station will mutate the data about it (common in Australia).
3. Add a new timer.
4. Set the timer as repeating, daily.
5. Return after the 1st instance of the timer has been recorded.
6. In the EPG select the next instance of the program.
7. If the EPG data is an match the Green button will be "Change timer", return to step 2.
8. If the EPG data is an impossible match the EPG cell will not be highlighted, return to step 2.
9. If the EPG data is an approximate match the EPG cell will be highlighted, but the Green button will be "Add timer".

[IanSav]

The issue was updated with the following change(s):

• The status has been updated, from New to Confirmed.

[IanSav]

The issue was updated with the following change(s):

• This issue's description has been changed

[Peter Urbanec]

The issue was updated with the following change(s):

• The category has been updated, from Not determined to Application / User Interface.

[Peter Urbanec]

The issue was updated with the following change(s):

• The status has been updated, from Confirmed to Testing.

[prl]

I don't think that the bug describes the cause. The cause is that the matching for Add timer/Change timer in EPGSelection.RecordTimerQuestion() is done on the basis of the event EIT id, not on the time:

    def RecordTimerQuestion(self, manual=False):
        ...
        for timer in self.session.nav.RecordTimer.timer_list:
            if timer.eit == eventid and is same service:

This can be confirmed by creating a daily repeating timer for a daily show that has the same broadcast time for each episode currently in the EPG. The first instance of the show in the EPG will show "Change timer", but subsequent instances will show "Add timer".

After the first instance has recorded, all of the instances in the EPG will show "Add timer" in the slot, whether they have retained the same start time and duration or whether it has changed, even though they are correctly coloured as recordings.