Disk check message while time-shift active is full of errors

While you have an active time-shift buffer and you try to perform a disk check on the hard drive the pop up message that warns the user of this situation is full of errors. On the way to displaying this message the drive selected confirmation message is not aligned with its bounding frame.

The message reads: Do you really want to check the filesystem? This could take a long time!

You seem to be in timeshft, the service wil breifly stop as timeshfit stops. Do you want to continue?

yes no

This might be better spelled and displayed as: Do you really want to check the file system? This could take a long time!

You seem to be in time-shift, the service will briefly stop as time-shift stops.

Do you want to continue? yes no

I am not sure about the meaning of the message in the second paragraph. I suspect that the message is trying to say: You appear to be in time-shift mode, time-shift mode will be suspended while the file system check is running.

So the final improved version could be: Do you really want to check the file system? This could take a long time!

You appear to be in time-shift mode, time-shift mode will be suspended while the file system check is running.

Do you want to continue? yes no

The code responsible for these messages is in /usr/lib/enigma2/python/Screens/HarddiskSetup.py

def hddQuestion(self, answer=False):
    print 'answer:',answer
    if Screens.InfoBar.InfoBar.instance.timeshiftEnabled():
        message = self.question + "\n\n" + _("You seem to be in timeshft, the service wil breifly stop as timeshfit stops.")
        message += '\n' + _("Do you want to continue?")
        self.session.openWithCallback(self.stopTimeshift, MessageBox, message)
    else:
        message = self.question + "\n" + _("You can continue watching TV etc. while this is running.")
        self.session.openWithCallback(self.hddConfirmed, MessageBox, message)

and def doIt(self, selection): self.session.openWithCallback(self.close, HarddiskSetup, selection, action=selection.createCheckJob, text=("Check"), question=("Do you really want to check the filesystem?\nThis could take a long time!"))[/code]

Reproduction steps

From live TV after enough time for time-shift mode to become active press "MENU > Setup > Storage > Filesystem Check".
Select the current hard drive used for time-shifting.
When selected you should note that the hard drive confirmation message is shown below and to the right of the box frame meant to contain the message.
Then press the RED button to start the check.
The messages as listed in the bug report should appear.

Comments (10)