Movie Player won't create Deleted Items folder

Issue #220 resolved
prl created an issue

If the default Movie Player (MEDIA) folder doesn't have a Deleted Items (.Trash in the file system) folder, then when a recording is deleted for the first time in the folder, you get an error popup, rather than the folder being created and the recording moved to it:

Cannot move to trash can
'Nonetype' object has no attribute 'endswith'
yes/no

If you answer yes, the recording is deleted immediately, if you answer no, the recording isn't deleted.

Reproduction steps

This assumes that the default movie location is the default setting: /media/hdd/movies

If you already have a Deleted Items entry in the Movie Player, exit Movie Player if you are in it and delete /media/hdd/movies/.Trash using either the File Commander or the commandline interface.

Create a test recording.

Enter the Movie Player (MEDIA). Press RED Delete on the test recording.

Produces the popup:

Cannot move to trash can
Nonetype object has no attribute 'endswith'
yes/no

Comments (8)

  1. prl reporter
    • removed issue_update
    • removed issue_reproducability

    The issue was updated with the following change(s):

    • This issue's reproduction steps has been changed
    • This issue's description has been changed
  2. prl reporter

    The bug can be worked around by using the File Commander or command-line interface to create a .Trash subfolder in the recording folder.

  3. Ian Brabham

    This is definitely a reversion. I explicitly tested this recently, within the last 5 or 6 weeks.

    However I did not test doing the first delete ever on a disk from a subdirectory.

    Also note there is only one trashcan per disk. Deleting recordings from sub-directories moves the recording to the disks trashcan. This also applies to networked access when the proper trashcan structure exists.

  4. prl reporter
    • removed issue_update
    • removed issue_reproducability

    Changed the Steps to reproduce considerably. The original steps made some incorrect assumptions about how the Delete Items folder works.

  5. prl reporter
    • removed issue_update
    • removed issue_reproducability

    The issue was updated with the following change(s):

    • This issue's reproduction steps has been changed
    • This issue's description has been changed
  6. Peter Urbanec
    • removed issue_status

    The issue was updated with the following change(s):

    • The status has been updated, from New to Implemented.
  7. Peter Urbanec
    • removed issue_status

    The issue was updated with the following change(s):

    • The status has been updated, from Implemented to Testing.
  8. Peter Urbanec
    • removed issue_resolution
    • removed issue_percent
    • removed issue_close
    • removed issue_status

    The issue was updated with the following change(s):

    • The status has been updated, from Testing to Closed.
    • This issue has been closed
    • This issue's progression has been updated to 100 percent completed.
    • The resolution has been updated, from Not determined to Fixed.
  9. Log in to comment