The GUI does not honour itemHeight specifications in menus

[IanSav]

While revising the skin for the GUI I am trying to reduce the item height of some menu lists. I am using the itemHeight attribute to specify the desired item height. For example: <widget name="config" position="400,80" size="830,560" backgroundColorSelected="MenuSelected" font="Regular;25" enableWrapAround="1" itemHeight="35" scrollbarMode="showOnDemand" transparent="1" /> instead of <widget name="config" position="400,80" size="830,560" backgroundColorSelected="MenuSelected" font="Regular;25" enableWrapAround="1" itemHeight="50" scrollbarMode="showOnDemand" transparent="1" /> This correctly displays most menu items at the nominated height of 35 pixels. Any menu options that use LEFT or RIGHT to select from the available options is correctly shown in the 35 pixel space. Any selections made from the list of options is also correctly displayed.

However, the ON/OFF switch icon that should fit within the 35 pixels available is displayed vertically centred as though the original 50 pixels is still in force. Also, any entries that are editable via the remote control SMS mode or an attached keyboard are also shown vertically centred as though the original 50 pixel height is still in force. Note that forcing the vertical alignment attribute (valign="center") does not help.

All elements in the menu should follow the prescribed / defined attributes for the display.

I would like to raise the priority and severity of this issue as it makes changing the skin unworkable but accept that this is not as important as some of the other broken features.

Reproduction steps

As an example:

Edit the /usr/share/enigma2/easy-skin-aus-hd/skin_setup_system.xml skin file and change the "SetupConfig" screen block as follows from: <widget name="config" position="510, 100" size="720, 500" itemHeight="50" selectionPixmap="easy-skin-aus-hd/menu/on_main_menu_705x50.png" backgroundColor="#41000000" scrollbarMode="showOnDemand" enableWrapAround="1" transparent="1"/> to: <widget name="config" position="510, 100" size="720, 500" itemHeight="35" backgroundColor="#41000000" scrollbarMode="showOnDemand" enableWrapAround="1" transparent="1"/> and restart the GUI when done.

Now go to the "MENU > Setup > System > GUI Setup" menu and move the cursor up and down the options. You should note that all the switch icons are displayed at the bottom of their slot and not centred like the other items. The buttons appear to be vertically centred on a 50 pixel item height and not the 35 pixels specified.

Now go to the "MENU > Setup > System > Time Settings" menu and move the cursor up and down the options. You should note that the "Timezone", NTP Server" and Sync NTP every (minutes)" entries are correctly displayed even if the LEFT and RIGHT buttons are used to change the settings.

Now go to the "NTP Server" entry and note that the text is centred when this item is NOT selected but drops when the item is currently selected for editing. The text now appears to be vertically centred on the original 50 pixel item height and not the 35 pixels specified.

All visual elements should follow and specified formatting options. It is fine to have a 50 pixel default height in the editing code but if an itemHeight is specified then the specified height should be used.

[IanSav]

A file was uploaded. reference to attachment Setup1.jpg (GUI Setup menu with a 35 pixel itemHeight looking correct.)

[IanSav]

A file was uploaded. reference to attachment Setup2.jpg (GUI Setup menu with a 35 pixel itemHeight showing the switch icon offset from vertical centre.)

[IanSav]

A file was uploaded. reference to attachment Setup3.jpg (Time Settings menu with a 35 pixel itemHeight looking normal.)

[IanSav]

A file was uploaded. reference to attachment Setup4.jpg (Time Settings menu with a 35 pixel itemHeight scrolling through "Timezone" settings with itemHeight preserved.)

[IanSav]

A file was uploaded. reference to attachment Setup5.jpg (Time Settings menu with a 35 pixel itemHeight with the NTP server selected and the text is no longer vertically centred.)

[IanSav]

A file was uploaded. reference to attachment Setup6.jpg (Time Settings menu with a 35 pixel itemHeight with the NTP server selected for editing and the text is no longer vertically centred.)

[Ian Brabham]

The issue was updated with the following change(s):

• The severity has been updated, from Normal to Major.
• The status has been updated, from New to Confirmed.

[Peter Urbanec]

The issue was updated with the following change(s):

• The severity has been updated, from Major to Normal.

[Peter Urbanec]

The issue was updated with the following change(s):

• The status has been updated, from Confirmed to Implemented.

[Peter Urbanec]

The issue was updated with the following change(s):

• The status has been updated, from Implemented to Testing.

[Peter Urbanec]

The issue was updated with the following change(s):

• The status has been updated, from Testing to Closed.
• This issue has been closed
• This issue's progression has been updated to 100 percent completed.
• The resolution has been updated, from Not determined to Fixed.

[IanSav]

This issue has not been completely fixed.

For example the itemHeight is not respected in the "MENU > Setup" main set up menu or the "MENU > Setup > Network > Network Adapter Selection > LAN connection" menu. (The menu below all available network devices in the Network Adapter Selection list suffer the itemHeight issue.)

The issue was updated with the following change(s):

• The status has been updated, from Closed to Reopened.
• This issue has been reopened
• The resolution has been updated, from Fixed to Not determined.
• This issue's progression has been updated to 0 percent completed.

[IanSav]

A file was uploaded. reference to attachment ItemHeight1.jpg (Main Setup menu with a 35 pixel itemHeight looking incorrect.)

[IanSav]

A file was uploaded. reference to attachment ItemHeight2.jpg (Network Setup menu with a 35 pixel itemHeight looking incorrect.)

[Peter Urbanec]

There are several hundred instances in both the main enigma2 code and various plugins where the code sets a specific itemHeight for certain items. A skin author needs to cope with this as in a number of instances, this is required.

There may be some specific cases where the code may not need to specify an itemHeight and such decision could be deferred to the skin author. However each such instance will need to be dealt with individually, taking into account compatibility with third party skins.

The underlying mechanisms for dealing with various itemHeight specifications have been fixed at the rendering level.

Please open individual bugs for instances where the code sets/uses a specific itemHeight and you need to override it. We can deal with each case depending on what the underlying code does. Please be aware that in some instances such bugs may be closed as WILL NOT FIX, if it turns out that making such changes is an incompatible change or has high risk / high impact factor.

The issue was updated with the following change(s):

• The status has been updated, from Reopened to Closed.
• This issue has been closed
• This issue's progression has been updated to 100 percent completed.
• The resolution has been updated, from Not determined to Fixed.

[IanSav]

This bug report was closed as FIXED while the two cases nominated on the REOPEN as still broken remain broken in 20140617.

[IanSav]

The issue was updated with the following change(s):

• The status has been updated, from Closed to Reopened.
• This issue has been reopened
• The resolution has been updated, from Fixed to Not determined.
• This issue's progression has been updated to 0 percent completed.

[Peter Urbanec]

Please read comment 15.

The issue was updated with the following change(s):

• The status has been updated, from Reopened to Closed.
• This issue has been closed
• This issue's progression has been updated to 100 percent completed.
• The resolution has been updated, from Not determined to Fixed.

[IanSav]

Additional cases have been added, as requested, in comments 12, 13 and 14.

The issue was updated with the following change(s):

• The status has been updated, from Closed to Reopened.
• This issue has been reopened
• The resolution has been updated, from Fixed to Not determined.
• This issue's progression has been updated to 0 percent completed.

[IanSav]

There have been many changes since this issue was created. Most of the problems have been resolved.

Any specific remaining issues can have a new issue created.