Name-based search in Movie Player can cause crash

In the Movie player, there is a facility for search by name. When the remote is used, it's on the first character of the name, and when a keyboard is used, it's on the matching initial string of the name.

When searching by name, the search starts at the entry below the current highlighted entry, and wraps around to the top of the list, and down to the current entry.

If the browser list does not show '..' as the first list entry (i.e. the list contains Deleted Items before '..') and the search wraps around the top, it causes a crash.

The cause is that the list entry for '..' has an info element that is None, and the code skips over the '..' entry by starting the wraparound search at the second item in the list. This only works if '..' is the first list item. If Deleted Items is in the list, the wraparound search starts with the second list entry and crashes when it accesses the list entry for '..'.

I have coded and tested a fix for this, but I'm waiting on other changes to Components/MovieList.py to be accepted before I make the code fixes available.

Reproduction steps

It may be helpful to sort the Movie Player list A->Z to make the reproduction easier.

Press MEDIA from Live TV, then navigate down the list so that some potential search entries are above the highlight.

Then enter a search character using the remote numerical keypad (2 for 'a', 2,2 for 'b', etc). The search character should not be a match for the first character of a name (folder or recording) below the current highlight (it may, but need not, match the first character of a name below the current highlight.

The search will start, and immediately crash the UI.

I've marked reproducibility as always, even though not all searches crash the UI. However, all searches that wrap around to the top of the search list will crash the UI.

Comments (4)