Change Timer menu not removed in Event View

In single event view (e.g. INFO from Live TV), if there is a timer running on the event and the GREEN button hint is showing Change Timer, pressing GREEN to change the timer, and then GREEN for delete timer deletes the timer, but the Change Timer menu stays on the screen. If GREEN is pressed again, the GUI crashes (crash log attached).

The cause is that while EventViewBase.showChoiceBoxDialog() and EventViewBase.closeChoiceBoxDialog() correctly disable the base class's ActionMaps while the Change Timer menu is active, the derived class EventViewEPGSelect adds ActionMaps which are not disabled. One of the action maps has a timerAdd() action for GREEN, so the Change Timer menu is created twice, but is only removed once. The crash occurs on the second push of GREEN after the timer has been deleted, because the timer no longer exists in the timer list, and the remove function throws an exception.

The BLUE Change Timer entry in the menu is not affected by this problem, because EventViewEPGSelect does not bind BLUE to any actions.

The Change Timer menu also uses GREEN for Delete Timer and Blue for Change timer, this should be changed to RED and GREEN for compatibility with the similar Change Timer operation in the EPG screens.

The Change Timer menu covers the green Change Timer button hint, it should stand above the button, similar to the wat the menu appears in the EPG below/above the affected item.

I have fixes for this bug ready to check in to the repository.

Reproduction steps

From Live TV, INFO, to get the Event Viewer. Then GREEN, GREEN to create a timer for the (current) event.

Then GREEN for Change Timer, GREEN again for Delete Timer. The timer is deleted (the green button hint changes to Add Timer, but this is not visible under the menu), but the menu stays on the screen.

Pressing GREEN again causes a GUI crash.

Comments (2)