Zap timers cause the following event to be shown as another zap timer
Issue #273
resolved
While refining the UI of the Graphical EPG I noticed the following anomaly. This report should be read in conjunction with the attached image.
When creating a zap timer the event following the zap timer event is also displayed as an active zap timer.
The attached screenshot shows the EPG state after a recording timer for Shark LiftAway 5-in-1 Steam cleaner was converted to a zap timer. The following event, Nutribullet, is displayed as having a zap timer, but no zap timer was added for that event. Converting a recording timer to a zap timer s not necessary to trigger this bug. Any zap timer has the same problem.
Reproduction steps
To see this bug, MENU>Setup>TV>Recording settings>Margin after recording (minutes) must not be 0.
In the Graphical EPG (text or graphics mode), select an event that doesn't cross the "now" line create a zap timer (GREEN Add Timer, then change Timer type to zap).
The event will be correctly displayed in the EPG as a zap timer, but the event directly after it will also be incorrectly displayed as a zap timer.
If the event with the incorrect timer highlight is navigated to, its GREEN button action will be Add Timer, not Change timer, which it should be if there was a real timer for that event.
Only a single timer will be created in /etc/enigma2/timers.xml, and it will have the correct start and end times.
This bug also occurs if an existing record timer is changed to be a zap timer.
If MENU>Setup>TV>Recording settings>Margin after recording (minutes) is set to 0, this bug will not occur on newly created zap timers.
Comments (6)
-
reporter
-
- removed issue_status
The issue was updated with the following change(s):
- The status has been updated, from New to Confirmed.
-
- I have tested this with no other timers in the T3. Creating the timer as a record timer, and changing it to a zap timer causes the following program to be marked as a zap timer. But it doesn't seem to be anything to do with the change of timer type. If the timer is created as a zap timer initially, it still has the same problem.
- There isn't really a timer on the second event, because the GREEN button on it has the add timer, not the change timer function.
- There is only one timer created in /etc/timers, and it's for the correct times.
- The incorrect timer marking doesn't happen when post-padding is set to 0. Although that's not a useful workaround, it may point towards the problem.
-
- removed issue_reproducability
- removed issue_update
The issue was updated with the following change(s):
- This issue's description has been changed
- This issue's reproduction steps has been changed
-
I have found the code that does this. It appears to be deliberate. There is no comment to enlighten the reader as to why it was done. It doesn't do it for repeating zap timers.
-
- removed issue_resolution
- removed issue_percent
- removed issue_close
- removed issue_status
The issue was updated with the following change(s):
- The status has been updated, from Confirmed to Closed.
- This issue has been closed
- This issue's progression has been updated to 100 percent completed.
- The resolution has been updated, from Not determined to Fixed.
- Log in to comment
A file was uploaded. reference to attachment EPGZapTimer.jpg (Screen capture showing the correct recording timer and zap timers, one correct the other incorrect.)