Spinner position incorrectly calculated

A number of people have noted that the new elliptical ball spinner appears to be shifted to the right. I believe this is due to an invalid calculation of where to place the spinner.

The current spinner location appears to be based on the original "cog" spinner that shipped with the original firmware. The position appears to be calculated as: x = (screen_width / 2) - (cog_spinner_width / 2) y = (screen_height / 2) - (cog_spinner_height / 2) + Beyonwiz_logo_offset The problem is the new elliptical ball spinner is wider than the original cog spinner. (In this case the height doesn't matter as a logo bias has been added but really should be taken into consideration.)

This should become: x = (screen_width / 2) - (current_spinner_width / 2) y = (screen_height / 2) - (current_spinner_height / 2) + Beyonwiz_logo_offset where the spinner dimensions are obtained from the current or active spinner. Note that the boot spinner may be replaced by a skin based spinner so the location may need to change!

I would also like to see the "Beyonwiz_logo_offset" deleted so that the spinner is truly centred on the screen. The Beyonwiz wall papers can be changed so that the actual logo is positioned in such a way that a clash with a reasonable range of spinner sizes is avoided. Perhaps the Beyonwiz logo can be moved towards the top and left of the screen and the "T3" model logo can be added to one of the other corners.

Thus the spinner position should return to what I assume to be the original: x = (screen_width / 2) - (current_spinner_width / 2) y = (screen_height / 2) - (current_spinner_height / 2)

Reproduction steps

The spinner position can be confirmed while watching the T3 boot. The spinner appears below the Beyonwiz logo and to the right.

Comments (3)