SUBTITLE and AUDIO buttons should have consistent UI paradigm

Issue #293 resolved
Peter Urbanec created an issue

Currently SUBTITLE and AUDIO buttons have very different user interface paradigms for what are essentially similar user interface requirements.

I propose a more consistent behaviour:

  • Short press to cycle through available tracks
  • Long press to show the full menu, including config options.

For audio, you start at first audio track and cycle through all available tracks.

For subtitles, you would have "No subtitles" as the first track, then all available subtitles as additional entries.

In each instance, the user preferences would attempt to select a track that matches the selected configuration and fall-back to the first track. In the case of audio, the first track would be the default sound track and in the case of subtitles it would be no subtitles.

Comments (4)

  1. Peter Urbanec reporter

    Fix issue #293 - SUBTITLE and AUDIO UI paradigm - add cycle through subtitles

    [keymap] Add entry for long-SUBTITLE and change short-SUBTITLE to break instead of make.

    The operations attached to short/long SUBTITLE and AUDIO will be swapped in a later commit.

    [AudioSelection]

    Separate out static methods for subtitle language and subtitle description for reuse in the implementation of InfoBarSubtitleSupport.subtitleToggle().

    Add config entries in SUBTITLE popup to allow undefined language teletext streams to be hidden.

    Implement the option to hide undefined language teletext streams in the subtitle list.

    Add documentation for subtitle tuple.

    Remove unnecessary [:5] when setting the subtitle.

    [InfoBarSubtitleSupport]

    Add documentation for subtitle tuple.

    Implement cycling through subtitle streams, with the option to hide undefined language teletext streams.

    [UsageConfig]

    Add config variables for hiding undefined language teletext streams.

    → <<cset 5315a57b68cd>>

  2. Peter Urbanec reporter

    Fix issue #293 - SUBTITLE and AUDIO UI paradigm - add cycle through audio tracks

    [AudioSelection]

    Separate out static methods for audio language and audio description for reuse in the implementation of InfoBarAudioSelection.audioSelectionLong().

    Remove redundant fetch of audio track info.

    [InfoBarAudioSelection]

    Implement cycling through audio tracks.

    → <<cset c912b906fc5c>>

  3. Peter Urbanec reporter

    Fix issue #293 - SUBTITLE and AUDIO UI paradigm - swap long- and short-press actions for SUBTITLE and AUDIO

    [InfoBarSubtitleSupport]

    Swap long- and short-press actions for SUBTITLE.

    Correct id for notification popup.

    [InfoBarAudioSelection]

    Swap long- and short-press actions for AUDIO.

    Change ActionMap's description.

    → <<cset 3303c17c96be>>

  4. Log in to comment