Subtitle colours go black

Issue #319 resolved
Peter Urbanec created an issue

Multiple reports on the forums about subtitle colours (and possibly formatting) not working properly.

I noticed on ABC1 Midsummer Murders the second person speaking the colour was black. The workaround is to go to the subtitle menu and change the colour from "original" I think from memory to yellow or white or whatever. Of course this doesn't fix the real problem and introduces another ie if 2 or more people have subtitles there is no colour difference between the subs.

AND

The problem is that when SRT subtitle files are used the text mostly is fine (white with black outline). However many subtitle files use HTML coding where for example <b> is bold, <i> is italic, etc. The problem that we have is any subtitle (SRT) file that uses italic <i> appears on screen as black text which is of course mostly unreadable especially if the background is black.

Comments (7)

  1. prl

    The second part of this bug report, including a description of the ultimate cause, is covered in bug report 321

  2. prl

    For the problem in broadcast (not SRT) subtitles, it seems that the problem happens specifically if two (or more?) people have dialog lines on the screen at the same time. The dialog should show one colour for the first speaker and another colour for the second speaker, The first speaker's text (top line) is shown in the correct colour, but the second speaker's text (bottom line) is black.

    When the two speakers' dialog subtitles shown separately, so that only one speaker's dialog is shown at any one time, the text for both speakers is coloured correctly.

    This has been verified by me and two posters on the forum.

  3. prl

    The subtitle colour information for broadcast subtitles seems to be being handled correctly in

    eDVBTeletextParser::handleLine(unsigned char *data, int len)
    

    (in dvb/teletext.cpp)

    However, when the subtitle teletext page is rendered into text for display in

    eSubtitleWidget::setPage(const eDVBTeletextSubtitlePage &p)
    

    (in gui/esubtitle.cpp), like the SRT subtitle text, it also uses

    gRGB::operator const std::string () const
    

    (in gdi/gpixmap.h) to convert the gRGB colour of the text into a colour escape in the text.

    I think that if bug report 321 is fixed, both of the reported subtitle problems may be fixed.

  4. prl
    • removed issue_severity

    I've bumped this up from Minor to Normal, because I think that correct colouring of subtitles is important for people with hearing deficits, for whom the colours serve to help identify the speaker.

  5. prl
    • removed issue_severity

    The issue was updated with the following change(s):

    • The severity has been updated, from Minor to Normal.
  6. prl
    • removed issue_status

    The issue was updated with the following change(s):

    • The status has been updated, from New to Confirmed.
  7. Log in to comment