gRGB::operator const std::string () const conversion incorrect

Issue #321 resolved
prl created an issue
gRGB::operator  const std::string () const

is intended to produce an ARGB escape sequence that can be decoded by

gRGB::gRGB(const char *colorstring)

after stripping off the '\c' prefix. I.e. the conversion is supposed to be in the form \cAARRGGBB, where A, R, G, B are ASCII hex digits ('0'..'9', 'A'..'F', 'a'..'f').

The code will actually generate ASCII text with characters in the range '@'..'O' (letter 'O', not digit '0').

Reproduction steps

Read the code for

gRGB::operator  const std::string () const

in gdi/gpixmap.h.

One consequence of this is that colour escapes for external subtitles are not set correctly when MENU>Setup>TV>Subtitle settings>External subtitle color is set to anything other than "white".

Comments (1)

  1. Log in to comment