Long press REC to create ZAP timer does not set ZAP timer colour or icon

[IanSav]

In the various EPG views that show coloured grid cells if a ZAP timer is created by creating a timer and changing its type from RECORD to ZAP the timer highlight changes from red to green as is expected.

If you long press REC to immediately create a ZAP timer the timer is created but there is no highlighting and the "Z" indicator is not shown. Editing the timer shows that it appears to have been created properly. Editing this timer doesn't correct the lack of a hightlight. That is, changing the timer to a RECORD timer does not make the cell red.

[prl]

This seems to be deliberate. When a Zap timer is created using long-REC in the EPG, its start time is set to the event start time - pre-padding, and its duration is set to pre-padding + 1 minute. So the "partial clocks" display without the recording highlighting or the "Z" icon in the EPG is correct for the timer that is created.

Fixing it probably only needs:

        if self.timer.justplay:
            self.timer.end = self.timer.begin + (config.recording.margin_before.value * 60) + 1

to be deleted from Screens.TimerEntry.InstantRecordTimerEntry.__init__(), but I wonder what the rationale is for the values that are given to the timer.

[Peter Urbanec]

My guess would be that a zap timer is created as short as possible (i.e. one second) to prevent timer conflicts.

I guess that the semantics of a "zap" timer are to only change channel. I guess that could be different to a "view" timer, which may have the semantics of locking down the channel for the entire duration.

[prl]

It's possible to create a no-length Zap timer (set Set end time to "no" in TimerEdit screen when Timer type is zap).

[IanSav]

I believe that the default long REC should create a ZAP timer that runs the full length of the event plus padding as per any other RECORD type timer. If you want a different length recording then the timer can be edited as required.