Incorrect "unknown action" messages from ChoiceBox ActionMaps

Issue #468 resolved
prl created an issue

Button presses for many of ChoiceBox's ActionMap entries log "unknown action" warnings even though the actions are in fact defined in an ActionMap (just not the one producing the warnings)

Replication steps

Enable debug logging on the PVR.

Open any ChoiceBox (e.g. BLUE from live TV). Navigate using UP/DOWN. Look in the log. Each press of UP or DOWN produces:

KEY: 108 make KEY_DOWN ('DOWN',)
action ->  WizardActions down
unknown action WizardActions/down! typo in keymap?
action ->  WizardActions down

The action is actually carried out when the second action -> log entry is printed. The "unknown action" message isn't really appropriate.

Comments (3)

  1. Peter Urbanec

    Fix bug #468: Incorrect "unknown action" messages from ChoiceBox ActionMaps

    Change the priority of self["actions"] so that it is searched before self["cancelaction"]. This eliminates most of the spurious warnings.

    Add a "drop through" mapping for "back" in self["actions"] so that it no longer produces a spurious warning.

    Remove unused contexts from self["cancelaction"] and change it from NumberActionMap to ActionMap. This is just tidying-up and doesn't itself change the warnings once the other changes have been made.

    → <<cset 03d0ee14a1d9>>

  2. Log in to comment