Problems changing channels in the EPG while timeshifting

[prl]

There is a problem with the channel preview codecode that tries to determine whether it's the second press of OK on a channel assumes that when it asks for the channel to be changed, the change happens immediately. A side-effect of this is that is that the "Leave timeshift/..." popup is displayed twice. If the "Leave timeshift/..." popup appears and you he channel change is delayed from when the code expected it to be, and problems ensue.

If you select "Leave timeshift" in the popup you are sent back to live TV on the new channel, rather than previewing the channel in the EPG. If you elect to save timeshift in the popup (twice), you can get the timeshift saved twice.

Replication steps

MENU>Setup>TV>Timeshift settings

Show warning when timeshift is stopped: on
Timeshift save action on zap: Ask user

EPG, MENU:

Channel preview mode: on

Then from live TV: start viewing TV timeshifted (e.g. LEFT or PAUSE)

EPG

navigate to different channel

OK

Leave timeshift/ etc popup appears

OK to select Leave timeshift

Leave timeshift/ etc popup still there (it's a second popup)

Wait for at least the time set in MENU>Setup>TV>Timeshift settings>Automatically start timeshift after

OK to select Leave timeshift

EPG briefly flashes on the screen, and you're dropped into live TV in the new channel, rather than back in the EPG previewing it.

If you now wait until timeshift should have been started up, and try to skip back, you'll find that timeshift is broken (always shows an empty progress bar) and the image freezes.

Pressing STOP goes back to live TV.

Changing channel will restore