[NetworkBrowser] Non-alphanumerics poorly handled in local sharenames

The intention of the code in NetworkBrowser.AutoMount appears to be to only allow the characters "a-zA-Z0-9_" in local share names.

This is not cleanly handled and can lead to anomalies and replication of share entries.

The stripping on non-allowed characters needs to be applied consistently, and especially to AutoMount.old_sharename so that changes to the share name are properly detected.

Replication steps

Create a single network share mount of any type with a Local sharename containing only characters from "a-zA-Z0-9_" (tested on autofs/CIFS, but should apply to all mount types).

In MENU>Setup>Network>Mount manager>Mount management, select the mount and open its setup window. Add a single non-permitted character to the Local sharename ("%" for example). OK to save the change.

Examine the mount directory (using ls /media/autofs, for example). It should show the mount point containing the non-permitted character.

Re-enter the mount's setup window in Mount management. It will not show the non-permitted character to the Local sharename. Press OK to save without making any changes. The list of mounts in Mount management will now contain two entries for the mount point, one without the non-permittted character, and one with it, but one will be marked as not mounted, and that entry won't appear in ls /media/autofs.

There may be other consequences of the mishandling of the character stripping in NetworkBrowser.AutoMount.

Comments (1)