[NetworkBrowser] "Enigma2 old format" mounts can fail

[prl]

In NetworkBrowser, if a network share mount has a mount type "Enigma2 old format", it will only be visible if there are no network share mounts of other types.

Later operations on NetworkBrowser can remove the "old format" mount completely.

Replication steps

Set up the PVR to have only a single network share mount with "Mount using" set to "Enigma2 old format" (e.g. in MENU>Setup>Network>Network browser, after deleting any other share mounts in MENU>Setup>Network>Mountpoints manager>Mount management).

Exit Network browser and open Mount management. The new mountpoint will be listed.

Return to Network browser and create a second network share mount with a type other than "Enigma2 old format" (e.g. AUTOFS).

Return to Mount management. The original ("Enigma2 old format") entry will not be listed, but both mounts are still listed in /etc/enigma2/automounts.xml.

Open that mount point's setup screen and re-save the details with OK (no changes need to be made, but can be). The mountpoint remains, but now there is only one mount listed in /etc/enigma2/automounts.xml - the entry for the "Enigma2 old format" mount has been completely removed.

[Peter Urbanec]

My preferred approach to this would be to completely remove support for "Enigma2 old format" mounts, unless you can think of a compelling reason to keep them. Hopefully doing so will result in smaller and less complex code base.

[prl]

The fix is trivial, and only involves removing code, but I'm not against removing support for "Enigma2 old format" mounts completely. The fix simply needs the test on mountusing == 0 to be removed & when that is done all assignments to mountusing can be removed, because that test is the only place where mountusing is read.

The apparent complexity of AutoMount.getAutoMountPoints() can be reduced most by refactoring it to eliminate the copy/paste code that's used instead of a single method to initialise all combinations of "Mount using" and "Mount type" for the automounts dict, and that should probably be done independent of any fixes to this bug (or removal of the buggy feature).

[prl]

Proposed fix:

1. Refactor AutoMount.getAutoMountPoints() as suggested above.
2. Remove "Enigma2 old format" from the "Mount using" options, and convert all "Enigma2 old format" mount methods to "Enigma2" on reading automounts.xml. This will cleanly remove any old style mounts that happen to be out there.
3. In a later firmware update, remove all "Enigma2 old format" code.

[Peter Urbanec]

There were numerous changes to the code since this issue was raised. Would it be now appropriate to close this issue as resolved?