[TimerEditList] Crash when incorrect PIN entered

If parental controls are applied to the timer list, the timer list is entered (e.g. TIMER from live TV) and an incorrect PIN is entered 3 times, the UI crashes.

The error is that the callback in the error MessageBox opened in TimerEditList.pinEntered()is self.close and not self.closeProtectedScreen.

The cleanest fix is to simply add the ProtectedScreen mixin to TimerEditListand override ProtectedScreen.isProtected()appropriately. This is hindered by an unused import from Screens.ChannelSelection in Screens.ParentalControlSetup that causes an import dependency loop, so that import also needs to be removed. The incorrect cut/paste from ProtectedScreen into TimerEditList may have been motivated by the problem in importing ProtectedScreen into TimerEditList.

Replication steps

In MENU>Setup>TV>Parental control, set a PIN and enable Protect screens and Protect timer menu (other protection settings may remain as they are). Save the settings and exit back to live TV.

Then TIMER, enter the PIN incorrectly 3 times (just pressing OK without entering a PIN will also work), the GUI crashes on entering the 3rd incorrect PIN.

Comments (2)