RemoteControlCode plugin crashes on V2

Issue #731 resolved
prl created an issue

The V2 kernel doesn’t support remote code changes (no /proc/stb/ir/rc/type), and correctly doesn’t have the RemoteControlCode plugin pre-installed.

However, the plugin can be installed via PLUGIN, GREEN Download plugins, systemplugins>remotecontrolcode.

When the plugin is installed, and you do MENU>Setup>System>Remote control code setup, OK - crash. The crash is because of an uncaught exception when opening a non-existent /proc/stb/ir/rc/type.

The problem is that the RemoteControlCode plugin only attaches itself to WHERE_MENU if the proc file exists, but GeneralSetup adds the plugin to the setup menus if the RemoteControlCode plugin is installed, whether the proc file exists or not.

Comments (6)

  1. prl reporter

    I’m not sure what the best fix is here:

    • Catch the exception and show an error popup;
    • Only add the plugin to the GeneralSetup menus if the plugin is installed and the proc file exists (needs a new plugin method to test this so that GeneralMenu doesn’t need to know the file path);
    • Remove the plugin from the V2 download list.

  2. prl reporter

    No, V2-specific. Oops. But since there’s no V2 specific component name, I’ve changed it to enigma.

  3. Log in to comment