dicomhero_vcs_version.h should not be needed in the binary redistributable. Move it to the implementation folder
dicomhero_vcs_version.h is not needed in the interface include files and should be moved to the implementation folder.
Comments (25)
-
reporter -
reporter Addresses
#395. Allow generating version files in the source folder, so they are included in the source package.→ <<cset 415da2747e88>>
-
reporter Addresses
#395. Updated position of version files.→ <<cset a3c5a5e1dc7d>>
-
reporter Addresses
#395. Generate source package→ <<cset afed57a92374>>
-
reporter Addresses
#395. Corrected generation of version files in source tree.→ <<cset 8f855fc8450a>>
-
reporter Addresses
#395. Corrected setup.py→ <<cset b46a074f9f6a>>
-
reporter Addresses
#395. Add cmake flag to explicitly write vcs header in source tree→ <<cset 14df225ffce7>>
-
reporter Addresses
#395. Corrected temporary version include path in setup.py→ <<cset ee1cea92c31d>>
-
reporter Addresses
#395. Don't build source distribution in this branch (out of scope).→ <<cset e56af6211e04>>
-
reporter Addresses
#395. Added documentation for cmake flag DICOMHERO_VCS_FILE_IN_SOURCE_TREE→ <<cset 173bccb2a0f3>>
-
reporter Addresses
#395. Added step to build source distribution→ <<cset a9aa42ab7612>>
-
reporter Addresses
#395. Corrected path to source distribution→ <<cset 6b8f1d61e8e0>>
-
reporter Addresses
#395. Corrected source distribution artifact.→ <<cset c038e7efea01>>
-
reporter Addresses
#395. Create artifacts folder after creating the source distribution.→ <<cset bad65faeec5c>>
-
reporter Addresses
#395. Remove build folder from ignored folders for source package (caused empty source package on bitbucket pipeline).→ <<cset 545478b27d8d>>
-
reporter Addresses
#395. Test distribution build.→ <<cset a2a9491f70e0>>
-
reporter Addresses
#395. Corrected path to source when testing distribution.→ <<cset 1db432c54fd2>>
-
reporter Addresses
#395. Use Ninja to test distribution build, test python from source distribution.→ <<cset 31a6705646a4>>
-
reporter Addresses
#395. Exclude documentation from default built targets to avoid errors when building with multithreading ninja→ <<cset e72f20e6d4b7>>
-
reporter Addresses
#395. Renamed documentation package to "dicomhero_documentatiom"→ <<cset 01e5e3f64af6>>
-
reporter Addresses
#395. Build documentation out of source dir.→ <<cset aaba338e3b36>>
-
reporter Addresses
#395. Corrected target name→ <<cset ddfcfa19a10a>>
-
reporter Addresses
#395. Updated changes log.→ <<cset 5ee70fb049b0>>
-
reporter Addresses
#395and#396. Updated changes log.→ <<cset 9bf1a8f1b332>>
-
reporter - changed status to resolved
Resolves
#395and#396as per SOP DEVENH/2→ <<cset e333f40e48e4>>
- Log in to comment
Addresses
#395. Added version files when generated inside the source directory→ <<cset fc15b74b6eb1>>