Remove compilation warnings.

The latest modifications introduced several compilation warnings.
Remove the warnings.

On linux:

/opt/atlassian/pipelines/agent/build/test_build_distribution/gtest_install/include/gtest/gtest.h: In instantiation of 'testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = long unsigned int]':
/opt/atlassian/pipelines/agent/build/test_build_distribution/gtest_install/include/gtest/gtest.h:1377:23:   required from 'static testing::AssertionResult testing::internal::EqHelper::Compare(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = long unsigned int; typename std::enable_if<((! std::is_integral<_Tp>::value) || (! std::is_pointer<_T2>::value))>::type* <anonymous> = 0]'
/opt/atlassian/pipelines/agent/build/test_distribution/dicomhero6-0.0.0.0-Source/dicomheroCore6/tests/dataSetTest.cpp:62:9:   required from here
/opt/atlassian/pipelines/agent/build/test_build_distribution/gtest_install/include/gtest/gtest.h:1358:11: warning: comparison of integer expressions of different signedness: 'const int' and 'const long unsigned int' [-Wsign-compare]
 1358 |   if (lhs == rhs) {
      |       ^~
[161/1106] Building CXX object dicomheroCore6/CMakeFiles/dicomheroTests.dir/tests/dicomDirTest.cpp.o
[162/1106] Building CXX object dicomheroCore6/CMakeFiles/dicomheroTests.dir/tests/dicomCodecTest.cpp.o
In file included from /opt/atlassian/pipelines/agent/build/test_distribution/dicomhero6-0.0.0.0-Source/dicomheroCore6/tests/dicomCodecTest.cpp:4:
/opt/atlassian/pipelines/agent/build/test_build_distribution/gtest_install/include/gtest/gtest.h: In instantiation of 'testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = long unsigned int]':
/opt/atlassian/pipelines/agent/build/test_build_distribution/gtest_install/include/gtest/gtest.h:1377:23:   required from 'static testing::AssertionResult testing::internal::EqHelper::Compare(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = long unsigned int; typename std::enable_if<((! std::is_integral<_Tp>::value) || (! std::is_pointer<_T2>::value))>::type* <anonymous> = 0]'
/opt/atlassian/pipelines/agent/build/test_distribution/dicomhero6-0.0.0.0-Source/dicomheroCore6/tests/dicomCodecTest.cpp:220:45:   required from here
/opt/atlassian/pipelines/agent/build/test_build_distribution/gtest_install/include/gtest/gtest.h:1358:11: warning: comparison of integer expressions of different signedness: 'const int' and 'const long unsigned int' [-Wsign-compare]
 1358 |   if (lhs == rhs) {
      |       ^~
[163/1106] Building CXX object dicomheroCore6/CMakeFiles/dicomheroTests.dir/tests/exceptionsTest.cpp.o
[164/1106] Building CXX object dicomheroCore6/CMakeFiles/dicomheroTests.dir/tests/drawBitmapTest.cpp.o
[165/1106] Building CXX object dicomheroCore6/CMakeFiles/dicomheroTests.dir/tests/jpegCodecTest.cpp.o
In file included from /opt/atlassian/pipelines/agent/build/test_distribution/dicomhero6-0.0.0.0-Source/dicomheroCore6/tests/jpegCodecTest.cpp:2:
/opt/atlassian/pipelines/agent/build/test_build_distribution/gtest_install/include/gtest/gtest.h: In instantiation of 'testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = long unsigned int]':
/opt/atlassian/pipelines/agent/build/test_build_distribution/gtest_install/include/gtest/gtest.h:1377:23:   required from 'static testing::AssertionResult testing::internal::EqHelper::Compare(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = long unsigned int; typename std::enable_if<((! std::is_integral<_Tp>::value) || (! std::is_pointer<_T2>::value))>::type* <anonymous> = 0]'
/opt/atlassian/pipelines/agent/build/test_distribution/dicomhero6-0.0.0.0-Source/dicomheroCore6/tests/jpegCodecTest.cpp:99:21:   required from here
/opt/atlassian/pipelines/agent/build/test_build_distribution/gtest_install/include/gtest/gtest.h:1358:11: warning: comparison of integer expressions of different signedness: 'const int' and 'const long unsigned int' [-Wsign-compare]
 1358 |   if (lhs == rhs) {
      |       ^~

/opt/atlassian/pipelines/agent/build/test_distribution/dicomhero6-0.0.0.0-Source/dicomheroCore6/tests/xmlTest.cpp:327:59: warning: 'maxHighBit' may be used uninitialized [-Wmaybe-uninitialized]
  327 |                     for(unsigned int highBit = 7; highBit < maxHighBit; ++highBit)
      |                                                   ^~~~
/opt/atlassian/pipelines/agent/build/test_distribution/dicomhero6-0.0.0.0-Source/dicomheroCore6/tests/xmlTest.cpp:300:30: note: 'maxHighBit' was declared here
  300 |                 unsigned int maxHighBit;
      |                              ^~~~~~~~~~
[185/1106] Linking CXX executable dicomheroCore6/dicomheroTests
/usr/bin/ld: dicomheroCore6/CMakeFiles/dicomheroTests.dir/tests/dimseTest.cpp.o: in function dicomhero::tests::dimseTest_storeSCUInteroperabilityTest_Test::TestBody()': dimseTest.cpp:(.text+0xccf1): warning: the use of tempnam' is dangerous, better use `mkstemp'

In file included from /usr/include/c++/12/memory:75,
                 from /opt/atlassian/pipelines/agent/build/test_distribution/dicomhero6-0.0.0.0-Source/dicomheroCore6/library/include/dicomhero6/baseStreamInput.h:21,
                 from /opt/atlassian/pipelines/agent/build/test_distribution/dicomhero6-0.0.0.0-Source/dicomheroCore6/library/include/dicomhero6/dicomhero.h:17,
                 from /opt/atlassian/pipelines/agent/build/test_distribution/dicomhero6-0.0.0.0-Source/examples/c++/dicom2jpeg/dicom2jpeg.cpp:8:
In member function 'void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = const char*]',
    inlined from 'std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = const char*; _Dp = std::default_delete<const char*>]' at /usr/include/c++/12/bits/unique_ptr.h:396:17,
    inlined from 'int main(int, char**)' at /opt/atlassian/pipelines/agent/build/test_distribution/dicomhero6-0.0.0.0-Source/examples/c++/dicom2jpeg/dicom2jpeg.cpp:325:9:
/usr/include/c++/12/bits/unique_ptr.h:95:9: warning: 'void operator delete(void*, std::size_t)' called on pointer returned from a mismatched allocation function [-Wmismatched-new-delete]
   95 |         delete __ptr;
      |         ^~~~~~~~~~~~
/opt/atlassian/pipelines/agent/build/test_distribution/dicomhero6-0.0.0.0-Source/examples/c++/dicom2jpeg/dicom2jpeg.cpp: In function 'int main(int, char**)':
/opt/atlassian/pipelines/agent/build/test_distribution/dicomhero6-0.0.0.0-Source/examples/c++/dicom2jpeg/dicom2jpeg.cpp:305:83: note: returned from 'void* operator new '
  305 |             std::unique_ptr<const char*> ffArgv(new const char*[options.size() + 1]);
      |                                                                                   ^
In member function 'void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = const char*]',
    inlined from 'std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = const char*; _Dp = std::default_delete<const char*>]' at /usr/include/c++/12/bits/unique_ptr.h:396:17,
    inlined from 'int main(int, char**)' at /opt/atlassian/pipelines/agent/build/test_distribution/dicomhero6-0.0.0.0-Source/examples/c++/dicom2jpeg/dicom2jpeg.cpp:325:9:
/usr/include/c++/12/bits/unique_ptr.h:95:9: warning: 'void operator delete(void*, std::size_t)' called on pointer returned from a mismatched allocation function [-Wmismatched-new-delete]
   95 |         delete __ptr;
      |         ^~~~~~~~~~~~
/opt/atlassian/pipelines/agent/build/test_distribution/dicomhero6-0.0.0.0-Source/examples/c++/dicom2jpeg/dicom2jpeg.cpp: In function 'int main(int, char**)':
/opt/atlassian/pipelines/agent/build/test_distribution/dicomhero6-0.0.0.0-Source/examples/c++/dicom2jpeg/dicom2jpeg.cpp:305:83: note: returned from 'void* operator new '
  305 |             std::unique_ptr<const char*> ffArgv(new const char*[options.size() + 1]);
      |

On Mac:

[00:06:02] In file included from /Users/appveyor/projects/imebra-git/dicomheroCore6/tests/buildImageForTest.cpp:6:
[00:06:02] /Users/appveyor/projects/imebra-git/dicomheroCore6/tests/buildImageForTest.h:65:37: warning: implicit conversion changes signedness: 'long long' to 'unsigned long long' [-Wsign-conversion]
[00:06:02]                 difference += (1000 * static_caststd::int64_t(p0 - p1)) / range;
[00:06:02]                                ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~
[00:06:02] /Users/appveyor/projects/imebra-git/dicomheroCore6/tests/buildImageForTest.cpp:283:20: note: in instantiation of function template specialization 'dicomhero::tests::compareImages<unsigned char>' requested here
[00:06:02]             return compareImagesstd::uint8_t(pData0, pData1, hImage0.getSize(), highBit0);
[00:06:02]                    ^

‌

Comments (7)