Commits

Anonymous committed b1c53fa

sync w/ atlasoff

Comments (0)

Files changed (6)

+2012-04-16 Walter Lampl <walter.lampl@ cern.ch>
+	* UserDataSvc.cxx: Put addRef in queryInterface
+	* tag AthenaServices-01-56-09
+	
+2012-04-05 Walter Lampl <walter.lampl@ cern.ch>
+	* UserDataSvc.cxx: Downgrade per-event INFO message to DEBUG
+	* tagging AthenaServices-01-56-08
+
+2012-04-04  Sebastien Binet  <binet@cern.ch>
+
+	* tagging AthenaServices-01-56-07
+	* be explicit about empty body of while loops
+	* M src/AtRndmGenSvc.cxx
+	* M src/AtRndmGenSvc.cxx
+	* M src/AtDSFMTGenSvc.cxx
+
 2012-03-29 Walter Lampl
 	* Redesign (I)UserDataSvc. StoreGate based implementation
 	* tag AthenaServices-01-56-06

python/TPCnvDb.py

 
 from __future__ import with_statement
 
-__version__ = "$Revision$"
+__version__ = "$Revision: 321236 $"
 __author__  = "Sebastien Binet <binet@cern.ch>"
 __doc__ = """simple interface to the rootmap files to easily locate t/p cnvs"""
 

src/AtDSFMTGenSvc.cxx

 {
   bool allOK(true);
   engineIter i(m_engines.begin()), e(m_engines.end());
-  while (i!=e && (allOK=(0 != this->setOnDefinedSeeds(eventNumber,
-                                                      runNumber,
-                                                      (*i++).first))));
+  while (i!=e && 
+         (allOK=(0 != this->setOnDefinedSeeds(eventNumber,
+                                              runNumber,
+                                              (*i++).first)))) {
+    /*empty*/
+  }
+    
   return allOK;
 }
 
 AtDSFMTGenSvc::setAllOnDefinedSeeds(uint32_t theSeed){
   bool allOK(true);
   engineIter i(m_engines.begin()), e(m_engines.end());
-  while (i!=e && (allOK=(0 != this->setOnDefinedSeeds(theSeed, (*i++).first))));
+  while (i!=e && 
+         (allOK=(0 != this->setOnDefinedSeeds(theSeed, (*i++).first)))) {
+    /*empty*/
+  }
   return allOK;
 }

src/AtRanluxGenSvc.cxx

 {
   bool allOK(true);
   engineIter i(m_engines.begin()), e(m_engines.end());
-  while (i!=e && (allOK=(0 != this->setOnDefinedSeeds(eventNumber,
-						      runNumber,
-						      (*i++).first))));
+  while (i!=e && 
+         (allOK=(0 != this->setOnDefinedSeeds(eventNumber,
+                                              runNumber,
+                                              (*i++).first)))) {
+    /*empty*/
+  }
   return allOK;
 }
 
 AtRanluxGenSvc::setAllOnDefinedSeeds(uint32_t theSeed){
   bool allOK(true);
   engineIter i(m_engines.begin()), e(m_engines.end());
-  while (i!=e && (allOK=(0 != this->setOnDefinedSeeds(theSeed, (*i++).first))));
+  while (i!=e && 
+         (allOK=(0 != this->setOnDefinedSeeds(theSeed, (*i++).first)))) {
+    /*empty*/
+    }
   return allOK;
 }

src/AtRndmGenSvc.cxx

 {
   bool allOK(true);
   engineIter i(m_engines.begin()), e(m_engines.end());
-  while (i!=e && (allOK=(0 != this->setOnDefinedSeeds(eventNumber,
-						      runNumber,
-						      (*i++).first))));
+  while (i!=e && 
+         (allOK=(0 != this->setOnDefinedSeeds(eventNumber,
+                                              runNumber,
+                                              (*i++).first)))) {
+    /*empty*/
+  }
   return allOK;
 }
 
 AtRndmGenSvc::setAllOnDefinedSeeds(uint32_t theSeed){
   bool allOK(true);
   engineIter i(m_engines.begin()), e(m_engines.end());
-  while (i!=e && (allOK=(0 != this->setOnDefinedSeeds(theSeed, (*i++).first))));
+  while (i!=e && 
+         (allOK=(0 != this->setOnDefinedSeeds(theSeed, (*i++).first)))) {
+    /* empty */
+    }
   return allOK;
 }

src/UserDataSvc.cxx

      return;
    }
    m_cUserData=m_userData; //Store also as const pointer
-   msg(MSG::INFO) << "Successfully created UserDataStore Object with key " << m_key << endreq;
+   ATH_MSG_DEBUG("Successfully created UserDataStore Object with key " << m_key);
    AthenaBarCodeBase newEventABC; //Generate new AthenaBarCode
    m_userData->setEventABC(newEventABC.getAthenaBarCode());
    m_eventABC.setAthenaBarCode(newEventABC.getAthenaBarCode());
     // Interface is not directly available: try out a base class
     return AthService::queryInterface(riid, ppvInterface);
   }
-  //addRef();
+  addRef();
   return StatusCode::SUCCESS;
 }