Commits

ssnyder  committed ea7bda8

Fix coverity warnings.

  • Participants
  • Parent commits e432590
  • Tags CxxUtils-00-00-67

Comments (0)

Files changed (5)

+2010-08-18  scott snyder  <snyder@bnl.gov>
+
+	* tagging CxxUtils-00-00-66.
+	* share/StrFormat_test.ref: (new)
+	* src/MD5.cxx: Coverity warning fix.
+	* CxxUtils/fpcompare.h: Fix typos in comments.
+	* src/AthDsoCbk.c: Comment out printfs to stdout.
+
 2010-06-30  Sebastien Binet  <sebastien.binet@cern.ch>
 
 	* tagging CxxUtils-00-00-65

File CxxUtils/fpcompare.h

  *
  *@code
  *    bool compare (IParticle* a, IParticle* b)
- *    { return a->pt() > b->bt(); }
+ *    { return a->pt() > b->pt(); }
  @endcode
  *
  * then you should replace the comparison with a call to one of the
  *
  *@code
  *    bool compare (IParticle* a, IParticle* b)
- *    { return CxxUtils::fpcompare::greater (a->pt(), b->bt()); }
+ *    { return CxxUtils::fpcompare::greater (a->pt(), b->pt()); }
  @endcode
  *
  * Longer explanation:

File share/StrFormat_test.ref

Empty file added.

File src/AthDsoCbk.c

 ath_dl_hook_install() 
 {
   pthread_mutex_init(&ath_dl_hook_lock, NULL);
-  printf("AthDsoCbk: installing mutex in tid [%d]\n", pthread_self());
+  /*printf("AthDsoCbk: installing mutex in tid [%d]\n", pthread_self());*/
   /*   printf ("AthDsoCbk: setting dlopen hooks\n" ); */
   _dlfcn_hook = &ath_dl_hook;
 }
 void ath_dl_hook_release ()
 {
   _dlfcn_hook = 0;
-  printf ("AthDsoCbk: releasing library\n");
+  /*printf ("AthDsoCbk: releasing library\n");*/
   pthread_mutex_destroy(&ath_dl_hook_lock);
 }
 
 // MD5 simple initialization method
 MD5::MD5()    {
   init();
+  memset (buffer, 0, sizeof(buffer));
+  memset (digest, 0, sizeof(digest));
 }
 
 // MD5 simple initialization method