Add lexers for DASM16, Augeas, TOML, and Slash

#807 Merged at 37d0ff3
Repository
Freso
Branch
default
Repository
birkenfeld
Branch
default
Author
  1. Freso Fenderson
Reviewers
Description

Lexers copied unmodified from https://github.com/liluo/pygments-github-lexers which is available under a 2-clause BSD license (same as pygments), copyright 2012 to GitHub, Inc.

Fixes #1391 and #1150.

Comments (16)

  1. Anteru

    Thanks for the contribution, this looks all good, except for one thing – can you please add one example file for each language added, to make sure automated tests exercise those new lexers? Can be a minimal file, but I’m feeling uncomfortable adding new lexers without any way to exercise them easily.

    1. Freso Fenderson author

      Can you help me with how to update the source for this PR? I’ve force‐pushed changes, but they’re not getting reflected here, and I can’t figure out to do so. The only documentation I’ve been able to find claims that Bitbucket should autoupdate PRs when the branch changes, but it obviously isn’t (possibly because of the force‐pushing?).

      1. Anteru

        Uh, good question. Maybe try to push a normal change to the branch (not force push), and if that fails, try a new PR? I’m not an expert on Bitbucket usage, unfortunately 😞

      2. Freso Fenderson author

        So, according to a former Bitbucket dev, this should Just Work™. However, it seems a newer(/current?) employee, @Colin Wood broke it at some point and hasn’t fixed it yet… But maybe it’ll work if I create a branch and base a new PR off of that branch and then I should maybe be able to push away, forcefully or not. I guess I’ll do that…

    1. Freso Fenderson author

      Right. I got a bit put off/discouraged by Bitbucket being broken and having been broken for so long. I use both GitLab and GitHub almost on the daily and it just really irks me that something as fundamental as this doesn’t Just Work. 😕

      I’ll try and finish this off and then I’ll probably close this and make a new PR. I’ll try and do this today!

      1. Anteru

        Thanks! Sad to hear about those issues, unfortunately there’s not much I can do about Bitbucket being broken short of moving the project to Github wholesale 😞

        1. Anteru

          Dang. I’ll pull manually from there, sorry about this fun 🙂 I hope there are no major differences, but I suspect your example file is better than mine.

          1. Freso Fenderson author

            I mean, what you had already was probably good enough. I just wanted to point out that BB hadn’t pulled in the latest changes in my “branch”. 🙂 Anyway, I’m happy that TOML will be in the next pygments release! 🙌

        2. Anteru

          I tried again, merged your new TOML sample, and did a bunch of fixes to the TOML lexer as a result (see 3b4e6a7bcf4f.) That should do the trick, hopefully. Next time I’ll probably just merge right away instead of hoping for Bitbucket to catch up.