Pull requests

#25 Merged
Repository
robotadam robotadam
Branch
default
Repository
birkenfeld birkenfeld
Branch
default

Add JSON Parameter option in httpdomain, one minor fix

Author
  1. Adam Lowry
Reviewers
Description

I needed another naming option along side query and form parameter, as the HTTP call I was documenting used a JSON body instead of a x-www-form-urlencoded body or query arg. I saw I wasn't the only one, so here it is. https://groups.google.com/d/msg/sphinx-users/jwlzW07_WJc/dkXXzH1X2tAJ

There was also one undefined variable in an error handler.

  • Learn about pull requests

Comments (2)

  1. Adam Lowry author

    Replied via Bitbucket inbox, putting it here for reference:

    I had some discussions on this with my colleagues, and I don't think there's a perfect way to phrase this. A JSON body could be an object (mapping), a list, or even a native type like a string or "null", and they can be arbitrarily nested. So the difficulty is in explaining each of the keys in something like: { "foo": [ {"bar": "baz"}, {"bar": "blurz", "flurgh": 23} ], "also": null } In this context you could say "JSON key", "JSON parameter", "argument", etc. So far in our internal discussions key is winning, looks like.

    Perhaps "Parameter" as a general term could be used, that way it wouldn't be specific for JSON.