Takayuki Shimizukawa avatar Takayuki Shimizukawa committed 9befd4a

Fix test_linkcode.test_html fails with C locale and Python 3. Closes #1311

Comments (0)

Files changed (2)

 * PR#176: Make sure setup_command test can always import Sphinx. Thanks to
   Dmitry Shachnev.
 
+* #1311: Fix test_linkcode.test_html fails with C locale and Python 3.
+
 
 Release 1.2 beta3 (released Oct 3, 2013)
 ========================================

tests/test_linkcode.py

 import os
 from util import with_app
 
+
 @with_app(srcdir='(temp)', buildername='html', tags=['test_linkcode'])
 def test_html(app):
     app.builder.build_all()
 
-    fp = open(os.path.join(app.outdir, 'objects.html'), 'r')
-    try:
-        stuff = fp.read()
-    finally:
-        fp.close()
+    stuff = (app.outdir / 'objects.html').text(encoding='utf-8')
 
     assert 'http://foobar/source/foolib.py' in stuff
     assert 'http://foobar/js/' in stuff
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.