1. Georg Brandl
  2. sphinx

Commits

georg.brandl  committed d66197a

Escape " to " in HTML help attribute values. #25.

  • Participants
  • Parent commits a0ce774
  • Branches default

Comments (0)

Files changed (2)

File CHANGES

View file
  • Ignore whitespace
 
   - Added ``cmember`` role for consistency.
 
+Bugs fixed
+----------
+
+* Properly escape quotes in HTML help attribute values.
+
 
 Release 0.4.3 (Oct 8, 2008)
 ===========================

File sphinx/htmlhelp.py

View file
  • Ignore whitespace
                     write_toc(subnode, ullevel)
             elif isinstance(node, nodes.reference):
                 link = node['refuri']
-                item = object_sitemap % (cgi.escape(node.astext()), link)
+                title = cgi.escape(node.astext()).replace('"','"')
+                item = object_sitemap % (title, link)
                 f.write(item.encode('ascii', 'xmlcharrefreplace'))
             elif isinstance(node, nodes.bullet_list):
                 if ullevel != 0: