Links generated with :rfc: do not use TLS

Alex Gaynor avatarAlex Gaynor created an issue

They should be point at the "https" version of the URL. I believe this patch fixes the issue:

diff -r fac83bacaed5 sphinx/environment.py
--- a/sphinx/environment.py Sun Feb 02 08:05:59 2014 +0100
+++ b/sphinx/environment.py Mon Feb 03 10:07:54 2014 -0800
@@ -59,7 +59,7 @@
     'embed_stylesheet': False,
     'cloak_email_addresses': True,
     'pep_base_url': 'http://www.python.org/dev/peps/',
-    'rfc_base_url': 'http://tools.ietf.org/html/',
+    'rfc_base_url': 'https://tools.ietf.org/html/',
     'input_encoding': 'utf-8-sig',
     'doctitle_xform': False,
     'sectsubtitle_xform': False,
diff -r fac83bacaed5 tests/test_build_html.py
--- a/tests/test_build_html.py  Sun Feb 02 08:05:59 2014 +0100
+++ b/tests/test_build_html.py  Mon Feb 03 10:07:54 2014 -0800
@@ -129,7 +129,7 @@
         (".//li/tt/em/span[@class='pre']", '^i$'),
         (".//a[@href='http://www.python.org/dev/peps/pep-0008']"
             "[@class='pep reference external']/strong", 'PEP 8'),
-        (".//a[@href='http://tools.ietf.org/html/rfc1.html']"
+        (".//a[@href='https://tools.ietf.org/html/rfc1.html']"
             "[@class='rfc reference external']/strong", 'RFC 1'),
         (".//a[@href='objects.html#envvar-HOME']"
             "[@class='reference internal']/tt/span[@class='pre']", 'HOME'),

Comments (0)

  1. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.