Issues

Issue #1372 closed

Links generated with :rfc: do not use TLS

Alex Gaynor
created an issue

They should be point at the "https" version of the URL. I believe this patch fixes the issue:

diff -r fac83bacaed5 sphinx/environment.py
--- a/sphinx/environment.py Sun Feb 02 08:05:59 2014 +0100
+++ b/sphinx/environment.py Mon Feb 03 10:07:54 2014 -0800
@@ -59,7 +59,7 @@
     'embed_stylesheet': False,
     'cloak_email_addresses': True,
     'pep_base_url': 'http://www.python.org/dev/peps/',
-    'rfc_base_url': 'http://tools.ietf.org/html/',
+    'rfc_base_url': 'https://tools.ietf.org/html/',
     'input_encoding': 'utf-8-sig',
     'doctitle_xform': False,
     'sectsubtitle_xform': False,
diff -r fac83bacaed5 tests/test_build_html.py
--- a/tests/test_build_html.py  Sun Feb 02 08:05:59 2014 +0100
+++ b/tests/test_build_html.py  Mon Feb 03 10:07:54 2014 -0800
@@ -129,7 +129,7 @@
         (".//li/tt/em/span[@class='pre']", '^i$'),
         (".//a[@href='http://www.python.org/dev/peps/pep-0008']"
             "[@class='pep reference external']/strong", 'PEP 8'),
-        (".//a[@href='http://tools.ietf.org/html/rfc1.html']"
+        (".//a[@href='https://tools.ietf.org/html/rfc1.html']"
             "[@class='rfc reference external']/strong", 'RFC 1'),
         (".//a[@href='objects.html#envvar-HOME']"
             "[@class='reference internal']/tt/span[@class='pre']", 'HOME'),

Comments (6)

  1. Log in to comment