Issue #589 resolved

"build_sphinx" command fails to emit event and to clean up the builder

Sebastian Wiesner avatarSebastian Wiesner created an issue

The "build_sphinx" distutils command uses ".build_update()" or ".build_all()" directly instead of the generic ".build()" method. It therefore fails to emit the "build-finished" event, and it does not call "builder.cleanup()" (whatever this method does), because this is done in the ".build()" method.

Consequently "python setup.py build_sphinx" can produce slightly different results than calling "sphinx-build". To fix this, "setup_command.py" should use ".build()" instead of calling ".build_all()" and ".build_update()" directly. A patch is attached.

Comments (2)

  1. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.