Pull requests

#65 Declined
Repository
Deleted repository
Branch
default (378f73f7ff7c)
Repository
birkenfeld/sphinx sphinx
Branch
default

Use Babel.get_language() instead of parsing the language attribute.

Author
  1. Jakub Wilk
Reviewers
Description
No description
  • Learn about pull requests

Comments (3)

  1. Jakub Wilk author

    get_language() is broken in Docutils 0.8 (and only this version; it was fixed in 0.8.1). But then, writers/latex.py needs working get_language() in another place, so it won't work with Docutils 0.8 anyway. Other than this, yes, it should work with all supported Docutils versions.

  2. Jon Waltman

    The comment I made when I declined this isn't showing up so here it is again...

    Babel.get_language() now has a comment stating it obsolete and kept for backwards compatibility with Sphinx.

    As such, I don't think we need to add another call to it.

    Let me know or reopen the pull request if this is an issue.

    Thanks.