Pull requests

#133 Declined
Repository
Deleted repository
Branch
default (1b99f7e22f31)
Repository
birkenfeld/sphinx sphinx
Branch
default

add class variables which are templates of files in epub

Author
  1. Taku Shimizu
Reviewers
Description

I want to make epub3 builder in Sphinx. However, the current structure of epub builder in Sphinx prevents me from making it.

  • Learn about pull requests

Comments (4)

  1. Roland Meister

    Hi, nice that you want to work on an epub3 builder!

    Is there a reason to push the changes to the main repository right now?

    I would like to wait a little bit longer to keep a stable codebase. The changes can still be merged when you have a working builder.

  2. Taku Shimizu author

    Thank you for your comment!

    I understand what you said. I will send my pull request again when I make epub3 builder and it works well.

    Because it would take time to make epub3 builder which works well, would you close(reject) this pull request?