1. Georg Brandl
  2. sphinx
  3. Pull requests

Pull requests

#195 Open

Compile CHM files out of box

Bitbucket cannot automatically merge this request.

The commits that make up this pull request have been removed.

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update default
hg pull -r default https://bitbucket.org/mpasternak/sphinx
hg merge f352f26b667b
hg commit -m 'Merged in mpasternak/sphinx (pull request #195)'
  1. Michał Pasternak


I don't see any reason, why "htmlhelp" target make.bat on Windows should not try to build CHM help file.

CHM file building is the sole purpose of htmlhelp builder.

So, I added a variable to the make.bat file, that points to usual HTML Help Workshop location and voila, it works pretty good.

Why "PROGRA~2" and not %ProgramFiles(x86)%? Well, the second one causes problems, described here http://www.xinotes.org/notes/note/559/ or here http://www.blinnov.com/en/2010/06/04/microsoft-was-unexpected-at-this-time/ . After ~45 min of trying to have it working using environment variable, I gave up. PROGRA~1 should be "C:\Program Files" and PROGRA~2 should be "C:\Program Files(x86)", at least on the recent Windows 8.1 build.

Thank you very much for your work and making this software freely available.

Comments (6)

  1. Michał Pasternak author

    Well, yes, my fix is ugly. It's so bad, it may not be called a fix, because, as you, anatoly techtonik shown, it is environment-dependent.

    So, having in mind all the "special cases" of http://stackoverflow.com/questions/17688758/using-programfilesx86-on-windows-os-32bit http://stackoverflow.com/questions/9594066/how-to-get-program-files-x86-env-variable , I still won't have luck with the paren, that causes the "was unexpected at this time" bug in windows command interpreter http://stackoverflow.com/questions/9594066/how-to-get-program-files-x86-env-variable .

    Do you have any ideas, how to encode the path properly?

  2. Takayuki Shimizukawa

    I think that just executing the hhc.exe is the simplest and the most effective approach. Of course the user needs to setup PATH environment for hhc.exe. It would be good to display a message if execution failed.