ScratchAllocator::deallocate() runs into endless loop if buffer is used up exactly to the end

Johannes Spohr avatarJohannes Spohr created an issue

If the internal buffer is filled with allocations exactly to the end, so that _allocate == _end, the loop in memory.cpp, line 192 never returns, because _free will never reach _allocate.

Proposed solution: add a check in allocate(), just before assigning to _allocate:

...
  if (p == _end)
    p = _begin;
  _allocate = p;
  return data;
}

BTW: I think the loop in deallocate() does a load-hit-store on _free, so perhaps using a local variable would improve performance if there are a lot of small allocations in the default scratch allocator.

Comments (0)

  1. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.