Commits

Christian Ebert committed 3d69a1f

Provide safe hasattr() and use it in wget

Comments (0)

Files changed (2)

 
 import os, subprocess, sys
 
+_notset = object()
+
+def safehasattr(thing, attr):
+    '''Deal with python compatibility problems of hasattr().
+    See: http://selenic.com/hg/rev/5a0fdc715769'''
+    return getattr(thing, attr, _notset) is not _notset
+
+
 class DeadMan(Exception):
     '''Exception class for muttils package.
     '''
             self.opener.addheaders = headers
 
     def wwarn(self, url, inst):
-        if hasattr(inst, 'reason'):
+        if util.safehasattr(inst, 'reason'):
             self.ui.warn('failed to reach a server for %s\n' % url,
                          'reason: %s\n' % inst)
         else:
                 raise util.DeadMan('%s: invalid request instruction')
             fp.close()
         except urllib2.URLError, inst:
-            if hasattr(inst, 'reason'):
+            if util.safehasattr(inst, 'reason'):
                 self.ui.warn('failed to reach a server for %s\n' % req,
                              'reason: %s\n' % inst)
             else:
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.