- edited description
C++17 detection is too broad
Dear Klaus,
this is just to let you know that one of the recent commits to Blaze master (https://bitbucket.org/blaze-lib/blaze/commits/e9fc567e6bcd5ba11fd0611dc2f0863d60b75d2) breaks our builds. While this could be a temporary issue as you might be planning to augment those changes in the future, I'd like to suggest to make the detection of C++17 features a bit more fine-grained (instead of just looking at the __cplusplus
macro). The way you have set up things now will make all compilations fail that rely on a compiler that understands -std=c++17
(as the compiler itself is conforming) but that might not have all of the C++17 library features implemented (like std::uninitialized_move
, std::destroy
, etc.).
Thanks! Regards Hartmut
Comments (6)
-
reporter -
Hi Helmut!
Thanks a lot for pointing out this defect. Although unfortunately I apparently don't have a compiler with this property in my current test setup, I understand the problem and will fix it as quickly as possible. Thanks again,
Best regards,
Klaus!
-
-
assigned issue to
-
assigned issue to
-
- changed status to open
-
- changed status to resolved
-
reporter Thanks for the quick fix Klaus!
- Log in to comment