- edited description
Add MinGW defines to header includes in Time.h
To facilitate compilation with MinGW on windows, I believe that line 43 of blaze/util/Time.h
#if defined(_MSC_VER)
should be changed to something similar to:
#if defined(_MSC_VER) || defined(__MINGW64_VERSION_MAJOR) || defined(__MINGW32__)
See also issue #107
Comments (7)
-
reporter -
Hi Frank!
Thanks a lot for creating this issue and pointing out this problem. We will fix it as quickly as possible.
Best regards,
Klaus!
-
-
assigned issue to
-
assigned issue to
-
- changed status to open
-
Hi Frank!
I have pushed commit d747231, which contains the fix you suggested. Unfortunately I don't have a CI environment with MinGW available at the moment. Therefore I would appreciate if you could give it a quick try and see if it works as expected. Thanks a lot,
Best regards,
Klaus!
-
reporter That indeed works.
-
- changed status to resolved
Commit d747231 fixes the includes in the
<util/Time.h>
header. The fix is immediately available via cloning the Blaze repository and will be officially released in Blaze 3.6. - Log in to comment