catnip consumption increased

[Former user]

in https://bitbucket.org/bloodrizer/kitten-game/commits/3699ca2f35d72d33f807a1d3c4e402bca4b1e8c0 the formular for catnip consumption was changed. the old and new formular (outside anarchy mode) are not equivalent.

[coderpatsy]

Please state how they are different, so we don't miss something and spend minutes staring at it trying to discern a typo.

Specifically, it was changed from resConsumption *= [formula] to resConsumption += resConsumption * [formula]. @freeroot

[Arima B.]

second would be *= (1+formula), or roughly base 100% increase, if I understand correctly.

[freeroot]

The old one was buggy, so, when I updated for Idiot Kittens, I fixed it. The good behavior is to add special consumption for workers and when you have no workers at all, it must go on to consume catnip. The old one have a different behavior not expected.

Yes, the second part could be *= (1+formula) but it would have added some brackets creating confusing to read the formula.

[Thomas Lobig]

Hey guys, I signed up to be able to comment. So yeah, @bloodrizer is correct, the base consumption is added compared to the previous line. I described it here also: https://www.reddit.com/r/kittensgame/comments/5b99q5/greater_than_100_happiness_causing_very_large/

[Thomas Lobig]

If you absolutely want to retain the += notation, add bakets around the factors and subtract 1, i.e:

resConsumption += resConsumption * (this.village.happiness * (1 + this.getEffect(res.name + "DemandWorkerRatioGlobal")) * (1 - this.village.getFreeKittens() / this.village.sim.kittens.length) -1 );

then it's equivalent. I heard people complaining about the decreased catnip production (so actually increase in demand) in chat.

[freeroot]

Is it better ? https://bitbucket.org/bloodrizer/kitten-game/commits/8c33f3de35d6ab2a1be0de9c3baea66cc4009108