Loading save games repeatedly when coal upgrades are unlocked causes coal production to increase

[Joel Teichroeb]

Save a game with an upgrade such as geodesy unlocked. Load that save game multiple times. See coal output go up.

[Seth Leblanc]

I believe pull request #48 should fix this. Haven't tested this specifically with that change, but it should reset building effects on load, which is what causes this problem.

[Joel Teichroeb]

Now it resets the when reloading the page, but when importing a save game it will still increase the amount. Maybe we need to calculate the effects again after loading a save?

[Seth Leblanc]

My bad, didn't notice you mentioned geodesy specifically. Building effects are recalculated on load (importing and refreshing both call the same load function), which fixes the problem with e.g. mines continuing to produce coal even if the imported save doesn't have deep mining, but geodesy is handled differently. Geodesy and the drill upgrades are a mess atm, that calculation really needs to be centralized...

[coderpatsy]

Appears this was fixed back in in 96f4ccc

[Ross Smith]

Confirmed this seems to no longer be an issue in v 1.1.3.5

[coderpatsy]

I'll go ahead and close this then, thanks.