Philosopher leader bonus with Monarchy policy, and for burned paragon is calculated incorrectly

Issue #192 new
MM created an issue

By default philosopher leader reduces the prices by 10%.
With Monarchy policy, and no burned paragon philosopher leader currently reduces the prices by 10.95%.

While with doubled power it should reduce them by 19% (1 - 0.9*0.9)
The issue is in village.js, getEffectLeader
https://bitbucket.org/bloodrizer/kitten-game/src/master/js/village.js?at=master#lines-214
this.game.getLimitedDR(0.09 + 0.01 * burnedParagonRatio * leaderRatio, 1.0);
It multiplies the leaderRatio by 0.01 which is intended to only decrease burned paragon effect.
Now it also decreases the effect of philosopher with Monarchy policy.

there is also an issue with leaderRatio which is currently always set to 1.95

        var leaderRatio = 1;
        if (this.game.science.getPolicy("monarchy").researched){
            leaderRatio = 1.95;
        }

for Philosopher (and metallurgist) it should be 1.9, as their bonus is 10%.
for merchant should be 1.97 etc.

Comments (5)

  1. Log in to comment