TC Refine Ratio has no effect
The issue causing this is because it searches for the effect on the wrong tab. The function call for getting the ratio should be more like this.game.religion.getEffect("tcRefineRatio")
Comments (11)
-
-
@bloodrizer, do you know what's going on here with the web deploy?
-
So I tried patching in that fix -- it causes unicorn generation to go crazy due to double-counting of religion bonuses in resource computation.
-
OK. So we could either remove the "RELIGION EFFECTS" bit in
calcResourcePerTick
in game.js or we could change thesacrifice
function in religion.js to usethis.game.religion.getEffect("tcRefineRatio")
as this issue's filer suggests. I guess the latter is safer, depending on what other places are callinggame.getEffect
and expecting it to not pick up religion effects... The former seems better in terms of just centralizing all the effects stuff. -
My read of the code is that removing RELIGION EFFECTS would cause them to become additive instead of multiplicative. I suggest taking the latter route.
-
Hmm. I'm not sure why you think it would become additive instead of multiplicative. In both codepaths ("BUILDINGS AND SPACE EFFECTS" and "RELIGION EFFECTS") the code ends up multiplying
perTick
by1 + getEffect("unicornRatio")
(with getEffect called on different objects), right? So moving things so that it doesthis.getEffect("unicornRatio")
and gets nonzero seems the same as the current setup wherethis.getEffect("unicornRatio")
returns 0 and thenthis.religion.getEffect("unicornRatio")
returns nonzero... -
Hm, okay. I was worried that there might be places where both buildings/space and religion have the same ratio defined, and that would switch it from multiplicative (1+bld+space)*(1+religion) to additive (1+bld+space+religion).
-
Ah, that's fair. I can't speak for whether that can happen right now; I haven't looked through the code closely enough.
-
Has TC Refine Ratio now an effect ?
-
Yes, looks fixed now.
-
- changed status to resolved
- Log in to comment
This is actually fixed in the source, as part of https://bitbucket.org/bloodrizer/kitten-game/commits/cfdf99b8b889020806c2cd312c782c4bb5c6f647?at=master
But for some reason the updated game.js is not showing up on the actual kittens game website. :(