Bryan O'Sullivan avatar Bryan O'Sullivan committed 289b9d8

ByteString should not be an instance of the JSON type classes.

We can't know what its encoding is, so it's not safe.

Comments (0)

Files changed (1)

Data/Aeson/Types.hs

     ) where
 
 import Control.Applicative
-import Data.ByteString (ByteString)
 import Data.Map (Map)
 import Data.Text (Text, pack, unpack)
-import Data.Text.Encoding (decodeUtf8, encodeUtf8)
 import Data.Time.Clock (UTCTime)
 import Data.Time.Format (formatTime, parseTime)
 import Data.Vector (Vector)
     fromJSON _          = empty
     {-# INLINE fromJSON #-}
 
-instance ToJSON ByteString where
-    toJSON = String . decodeUtf8
-
-instance FromJSON ByteString where
-    fromJSON (String t) = pure (encodeUtf8 t)
-    fromJSON _          = empty
-
 mapA :: (Applicative f) => (t -> f a) -> [t] -> f [a]
 mapA f = go
   where
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.