Bryan O'Sullivan avatar Bryan O'Sullivan committed 84d0ecf

Fix an integer encoding bug, and add basic QuickCheck tests

Comments (0)

Files changed (3)

Data/Aeson/Encode/Int.hs

     | otherwise = go i
   where
     go n | n < 10    = digit n
-         | otherwise = go (n `rem` 10) `mappend` digit (n `quot` 10)
+         | otherwise = go (n `quot` 10) `mappend` digit (n `rem` 10)
 
 digit :: Int -> Builder
 digit n = fromWord8 $! fromIntegral n + 48
+ghc := ghc
+
+all: qc
+
+qc: Properties.hs
+	$(ghc) -o --make $@ $<
+
+clean:
+	-rm -f qc *.o *.hi

tests/Properties.hs

+import Data.Aeson.Encode
+import Data.Aeson.Types
+import Data.Attoparsec.Number
+import Test.Framework (defaultMain, testGroup)
+import Test.Framework.Providers.QuickCheck2 (testProperty)
+import Test.QuickCheck (Arbitrary(..))
+import Test.QuickCheck.Monadic (assert, monadicIO, run)
+import qualified Data.ByteString.Lazy.Char8 as L
+
+encodeDouble d  = encode (Number (D d)) == L.pack (show d)
+encodeInteger i = encode (Number (I i)) == L.pack (show i)
+
+main = defaultMain tests
+
+tests = [
+  testGroup "encode" [
+      testProperty "encodeDouble" encodeDouble
+    , testProperty "encodeInteger" encodeInteger
+    ]
+  ]
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.