Commits

Bryan O'Sullivan committed bbe7e0d

Rewrite arrayValues to be less combinator-driven

This gives us about a 20% performance increase when parsing an
array-heavy input, such as json-data/geometry.json (gh-134).

Comments (0)

Files changed (1)

Data/Aeson/Parser/Internal.hs

 arrayValues :: Parser Value -> Parser (Vector Value)
 arrayValues val = do
   skipSpace
-  vals <- ((val <* skipSpace) `sepBy` (char ',' *> skipSpace)) <* char ']'
-  return (Vector.fromList vals)
+  let loop = do
+        v <- val <* skipSpace
+        -- chr 44 == ',' && chr 93 == ']'
+        ch <- A.satisfy $ \w -> w == 44 || w == 93
+        if ch == 44
+          then skipSpace >> (v:) <$> loop
+          else return [v]
+  Vector.fromList <$> loop
 {-# INLINE arrayValues #-}
 
 -- | Parse any JSON value.  You should usually 'json' in preference to
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.