Commits

Steve Borho committed 5215e78

shlib: only send one shell notification per directory

This should improve the performance and possibly robustness
of large repository operations. It should not adversely effect
the shell overlays since it will get fewer refresh events and the
overlay code is already optimized to re-read entire directories.

Comments (0)

Files changed (1)

             from win32com.shell import shell, shellcon
         except ImportError:
             return
+        dirs = []
         for path in paths:
             abspath = os.path.abspath(path)
-            pidl, ignore = shell.SHILCreateFromPath(abspath, 0)
+            if not os.path.isdir(abspath):
+                abspath = os.path.dirname(abspath)
+            if abspath not in dirs:
+                dirs.append(abspath)
+        # send notifications to deepest directories first
+        dirs.sort(lambda x, y: len(y) - len(x))
+        for dir in dirs:
+            pidl, ignore = shell.SHILCreateFromPath(dir, 0)
             if pidl is None:
                 continue
             shell.SHChangeNotify(shellcon.SHCNE_UPDATEITEM, 
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.