James Bennett avatar James Bennett committed 8a1de44

Refactor the "already activated" string into a constant attached to RegistrationProfile

Comments (0)

Files changed (2)

registration/models.py

                 user = profile.user
                 user.is_active = True
                 user.save()
-                profile.activation_key = "ALREADY_ACTIVATED"
+                profile.activation_key = self.model.ACTIVATED
                 profile.save()
                 return user
         return False
     ``RegistrationManager``.
     
     """
+    ACTIVATED = u"ALREADY_ACTIVATED"
+    
     user = models.ForeignKey(User, unique=True, verbose_name=_('user'))
     activation_key = models.CharField(_('activation key'), max_length=40)
     
         
         """
         expiration_date = datetime.timedelta(days=settings.ACCOUNT_ACTIVATION_DAYS)
-        return self.activation_key == "ALREADY_ACTIVATED" or \
+        return self.activation_key == self.ACTIVATED or \
                (self.user.date_joined + expiration_date <= datetime.datetime.now())
     activation_key_expired.boolean = True

registration/tests.py

         self.failUnless(User.objects.get(pk=self.sample_user.pk).is_active)
         
         # The activation key must now be the string "ALREADY_ACTIVATED".
-        self.failUnlessEqual(RegistrationProfile.objects.get(user=self.sample_user).activation_key, u"ALREADY_ACTIVATED")
+        self.failUnlessEqual(RegistrationProfile.objects.get(user=self.sample_user).activation_key,
+                             RegistrationProfile.ACTIVATED)
         
         # Activating an expired user returns False.
         self.failIf(RegistrationProfile.objects.activate_user(RegistrationProfile.objects.get(user=self.expired_user).activation_key))
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.