1. Brodie Rao
  2. cram
  3. Issues
Issue #7 resolved

Allow selection of which shell the tests run under

Kamil Kisiel
created an issue

The default shell in cram is /bin/sh but for our purposes we have a lot of cases where it is more convenient to use bash syntax. It would be great if the shell cram ran tests under was selectable.

I've implemented the enhancement as a patch at https://bitbucket.org/kisielk/cram-mq/src/tip/shell

Please have a look and let me know what you think.

Comments (3)

  1. Brodie Rao repo owner

    Also, as an aside: I took a look at your pylint patch. As a rule, I don't use _ as a dummy variable because it conflicts with using it for gettext, and it's more confusing than seeing an unused variable with a full, descriptive name. The gettext thing isn't a problem right now, but I might add internationalization to Cram in the future.

    FWIW, I personally don't think Pylint should warn on unused variables defined using tuple assignment, and I've actually patched it locally to not do that.

  2. Kamil Kisiel reporter

    No problem with the pylint patch, it was mostly for my own purposes while hacking anyway. I figured there was a reason you hadn't done that yet :)

    Thanks for the quick feedback!

  3. Log in to comment