Commits

Burak Gürsoy committed 313f1e8

Perl::Critic fixes

Comments (0)

Files changed (1)

    return $self;
 }
 
-sub _config { return \%config }
+sub config { return \%config }
 
 sub run {
    local $SIG{__DIE__} = sub {
       # it is possible to get the url as "demo.pl??foo=bar"
       my $url = $self->{cgi}->can('self_url') ? $self->{cgi}->self_url
                                               : $self->{cgi}->url;
-      ($self->{program}, my @jp) = split m{\?}xms, $url;
+      ($self->{program}, my @jp) = split m{[?]}xms, $url;
    }
 
    my %options      = $self->all_options;
    my $ses  = shift || croak 'Security_code from session is missing';
    my $code = $self->{cgi}->param('code') || q{};
    my $pass = $self->iseq( $code, $ses );
-   my $meth = $pass ? '_congrats' : '_failure';
-   return $self->$meth( $code, $ses );
+   return $pass ? $self->_congrats( $code, $ses )
+                : $self->_failure(  $code, $ses )
+                ;
 }
 
 sub backenduri {
    my $self = shift;
    my $form = shift || return;
    my $ses  = shift || return;
-   return if $form =~ m{[^0-9]}xms;
+   return if $form =~ m{\D}xms;
    return $form eq $ses;
 }
 
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.