#54 Merged at 2b07304
Repository
Branch
piraha-mem
Repository
Branch
master
Author
  1. Steven R. Brandt
Reviewers
Description
  • Flesh: Support Darwin 17.5.0
  • Cactus: Support Darwin 17.6.0
  • Cactus: Support Darwin 17.7.0
  • Fix memory leak.
  • Remove print debug

Comments (3)

  1. Roland Haas

    If you change it from holding a smart_ptr to a regular ptr, how are you making sure that the pointee does not get deallocated once all other refs to it go away?

  2. Steven R. Brandt author

    The pointer is to a grammar object, which is, in turn, pointing to all the pattern elements it contains. Since the grammar object owns the lookup object, the lookup should not hold a pointer to the grammar. If it does, there is a cyclic reference which smart ptrs are not smart enough to clean up.