Better movement human player code

Issue #43 invalid
Anonymous created an issue

This is the final changed HumanPlayer.cpp file

Comments (8)

  1. Anonymous

    Does the HumanPlayer code in the Deathmatch have a crouch function yet? That would be a good improvement too.

  2. Carsten Fuchs

    Replying to [comment:1 Stephen]:

    Does the HumanPlayer code in the Deathmatch have a crouch function yet?

    Sorry, no, not yet.

    That would be a good improvement too.

    Agreed! XD

  3. Carsten Fuchs

    Replying to [ticket:43 bigjj13]:

    This is the final changed HumanPlayer.cpp file

    Thanks for your patch, but could you please explain the meaning and purpose of the local variable `Runspon`?

    For example, it's difficult to see (and explain) why this piece of code is like it is:

    if (Runspon!=0)
    {
        if (Runspon!=2)
        {
            WishVelocity=scale(WishVelocity, 4.0);   // Run
            if (Runspon==4) Runspon=4;
            else Runspon=3;
        }
    }
    

    `if (Runspon==4) Runspon=4;` makes sense only for the else-clause...

  4. Carsten Fuchs

    Thank you very much!

    A few questions though: - Do I assume right that Humanplayer.patch is obsolete? - (Are you aware that a patch can cover ''multiple'' files?) - It would be ideal if you could split the ticket in one that addresses the player movement (in a single patch) and another one that adds sounds (also in a single patch except for the `wav` files). This is the least important item in this list though; you may see [http://www.cafu.de/wiki/cppdev:submitpatches#make_atomic_patches Make atomic patches] for more details. - Please let me know about any obsolete or stale attachments that can or should be deleted. - `Ambient.caud` mentions otherwise unused sound shader `Sgcalarm`, please review! - Please see my notes in [comment:3 comment 3] above.

  5. Anonymous

    Hi,

    this new things will only work with my better human movement.

    Kan you please delete Humanplayer.patch? It has no use anymore.

    "Ambient.caud mentions otherwise unused sound shader Sgcalarm, please review!" Thanks ill check that.

    Ill add some comments later 3-4 days.

    Sincerely

    Admin(SG-O)

  6. Log in to comment