Pull requests

#3 Declined
Repository
armonge
Branch
default
Repository
carljm
Branch
default

Unittests failing due to a template syntax error

Author
  1. Andrés Reyes Monge
Reviewers
Description

The new syntax for sorl-thumbnail requires a closing endthumbnail tag for every thumbnail tag

  • Learn about pull requests

Comments (2)

  1. Carl Meyer repo owner

    Currently adminfiles is documented (in the README) as requiring sorl-thumbnail 3.2.5, not the newer versions. Also, the canonical way to run the tests is via tox (pip install tox; tox), and the tox.ini installs sorl-thumbnail 3.2.5, not the newer versions.

    I'd be happy to accept a pull request that switches to the newer sorl-thumbnail, but it can't just edit upload/base.html, it also needs to change the documentation to note the new minimum required version of sorl-thumbnail, and change tox.ini so that the tests run with the newer sorl-thumbnail.