1. Carlos Ribeiro
  2. Radio Tray
  3. Pull requests

Pull requests

#4 Open
Repository
lubosz
Branch
default
Repository
carlmig
Branch
default

Port Radio Tray to Gtk3 Gstreamer 1.2 Python3

Bitbucket cannot automatically merge this request.

The commits that make up this pull request have been removed.

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update default
hg pull -r default https://bitbucket.org/lubosz/radio-tray
hg merge bb606377b179
hg commit -m 'Merged in lubosz/radio-tray (pull request #4)'
Author
  1. Lubosz Sarnecki
Reviewers
Description

The "Updated url for Radio Paradise." commit is a rebasing fault. I was using the hg repo from SourceForge as a base of the port. Don't mind it.

Comments (3)

  1. Thomas Spura

    data/plugins/StationSwitcherPlugin.py needs to be ported too. In the last line is print "" and instead of gtk gi.repository should be used.

    Other than that it seems to work (at least partly).When clicking on anything, it takes quite long time till radiotray responses and acts on the clicking... On second startup gtk3 is crashing over here, so it might be a gtk3 issue... I have here gtk3-3.10.4-1.fc20.x86_64.

  2. Carlos Ribeiro repo owner

    Great job! In the background I was also porting to GTK3 and Gstreamer 1.0, but not to python 3. It seems to be working, but there could be some issues still, I haven't tested it thoroughly. Now, it's going to be interesting trying to merge this pull request with my version. Some things are probably equal, others aren't. I'm going to push my version first and see how this merges with it. However, I did have a few problems trying to use this pull, maybe related to python3 that I have to admit I haven't used yet.